[parser.c] Optimize unescaping unicode by directly writing to the output buffer. #922
Merged
byroot merged 1 commit intoruby:masterfrom Jan 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies
json_string_unescapeby havingconvert_UTF32_to_UTF8write directly to the outputbuffer. This saves aMEMCPYas theunescape_lenisn't known at a compile time so it isn't optimized away. At least that's what it seems based on thesamplyprofile:I'm pretty sure this doesn't introduce any potential out-of-bounds write as the current code in
masterunconditionally writesunescape_lenbytes tobufferwhereas this branch passesbufferdirectly toconvert_UTF32_to_UTF8which writes the sameunescape_lenbytes to thebuffer.Before
After
Benchmarking on my M1 Macbook Air shows a 2% improvement when parsing
activitypub.jsondepending on run.